> > On Sun, Oct 20, 2019 at 07:22:57PM -0500, Honnappa Nagarahalli wrote: > > Add functional tests for rte_ring_xxx_elem APIs. At this point these > > are derived mainly from existing rte_ring_xxx test cases. > > > > Signed-off-by: Honnappa Nagarahalli <honnappa.nagaraha...@arm.com> > > --- > > app/test/Makefile | 1 + > > app/test/meson.build | 1 + > > app/test/test_ring_elem.c | 859 ++++++++++++++++++++++++++++++++++++++ > > 3 files changed, 861 insertions(+) > > create mode 100644 app/test/test_ring_elem.c > > Given the few differences between test_ring_elem.c and test_ring.c, wouldn't > it be possible to have both tests in the same file?
+1 to reduce duplication... Might be move common code into .h file and have actual enqueue/dequeue calls as defines.