> -----Original Message----- > From: Raslan Darawsheh <rasl...@mellanox.com> > Sent: Wednesday, October 23, 2019 11:24 > To: Slava Ovsiienko <viachesl...@mellanox.com> > Cc: dev@dpdk.org > Subject: [PATCH] net/mlx: remove pedantic definition for icc > > Signed-off-by: Raslan Darawsheh <rasl...@mellanox.com> Acked-by: Viacheslav Ovsiienko <viachesl...@mellanox.com>
PS. The further considering of PEDANTIC removal at all is supposed. > --- > drivers/net/mlx4/Makefile | 5 ++++- > drivers/net/mlx5/Makefile | 5 ++++- > 2 files changed, 8 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/mlx4/Makefile b/drivers/net/mlx4/Makefile index > 25d7c75..0abdc8d 100644 > --- a/drivers/net/mlx4/Makefile > +++ b/drivers/net/mlx4/Makefile > @@ -67,7 +67,10 @@ endif > > # User-defined CFLAGS. > ifeq ($(CONFIG_RTE_LIBRTE_MLX4_DEBUG),y) > -CFLAGS += -pedantic -UNDEBUG -DPEDANTIC > +CFLAGS += -pedantic -UNDEBUG > +ifneq ($(CONFIG_RTE_TOOLCHAIN), "icc") > +CFLAGS += -DPEDANTIC > +endif > AUTO_CONFIG_CFLAGS += -Wno-pedantic > else > CFLAGS += -DNDEBUG -UPEDANTIC > diff --git a/drivers/net/mlx5/Makefile b/drivers/net/mlx5/Makefile index > 04de93a..0369ee6 100644 > --- a/drivers/net/mlx5/Makefile > +++ b/drivers/net/mlx5/Makefile > @@ -83,7 +83,10 @@ endif > > # User-defined CFLAGS. > ifeq ($(CONFIG_RTE_LIBRTE_MLX5_DEBUG),y) > -CFLAGS += -pedantic -UNDEBUG -DPEDANTIC > +CFLAGS += -pedantic -UNDEBUGi > +ifneq ($(CONFIG_RTE_TOOLCHAIN), "icc") > +CFLAGS += -DPEDANTIC > +endif > AUTO_CONFIG_CFLAGS += -Wno-pedantic > else > CFLAGS += -DNDEBUG -UPEDANTIC > -- > 2.7.4
