On Thu, Oct 3, 2019 at 6:10 PM Hemant Agrawal <hemant.agra...@nxp.com> wrote: > > Hi Jerin, > > > -----Original Message----- > > From: Jerin Jacob <jerinjac...@gmail.com> > > Sent: Thursday, October 3, 2019 4:04 PM > > To: Pavan Nikhilesh <pbhagavat...@marvell.com> > > Cc: Jerin Jacob <jer...@marvell.com>; Richardson, Bruce > > <bruce.richard...@intel.com>; Akhil Goyal <akhil.go...@nxp.com>; dpdk- > > dev <dev@dpdk.org>; Van Haaren, Harry <harry.van.haa...@intel.com>; > > mattias.ronnb...@ericsson.com; liang.j...@intel.com; Gujjar, Abhinandan > > S <abhinandan.guj...@intel.com>; Rao, Nikhil <nikhil....@intel.com>; > > Hemant Agrawal <hemant.agra...@nxp.com>; erik.g.carri...@intel.com > > Subject: Re: [dpdk-dev] [PATCH v5 00/10] example/l2fwd-event: introduce > > l2fwd-event example > > Importance: High > > > > On Thu, Oct 3, 2019 at 2:28 AM <pbhagavat...@marvell.com> wrote: > > > > > > From: Pavan Nikhilesh <pbhagavat...@marvell.com> > > > > > > This patchset adds a new application to demonstrate the usage of event > > > mode. The poll mode is also available to help with the transition. > > > > > > The following new command line parameters are added: > > > --mode: Dictates the mode of operation either poll or event. > > > --eventq_sync: Dictates event synchronization mode either atomic or > > > ordered. > > > > > > Based on event device capability the configuration is done as follows: > > > - A single event device is enabled. > > > - The number of event ports is equal to the number of worker > > > cores enabled in the core mask. Additional event ports might > > > be configured based on Rx/Tx adapter capability. > > > - The number of event queues is equal to the number of ethernet > > > ports. If Tx adapter doesn't have internal port capability then > > > an additional single link event queue is used to enqueue events > > > to Tx adapter. > > > - Each event port is linked to all existing event queues. > > > - Dedicated Rx/Tx adapters for each Ethernet port. > > > > > > v5 Changes: > > > - Redo poll mode datapath by removing all the static globals. > > > - Fix event queue configuration when required queues are not available. > > > - Fix Rx/Tx adapter creation based on portmask. > > > - Update release notes. > > > - Unroll macro used to generate event mode functions. > > > > > > > > > > Adding all eventdev maintainers. > > > > I have some minor comments on Documentation. Other than that, The series > > looks good to me in general. > > Anyone else planning to review this code. If yes, We will wait for merging > > this > > patch after RC1. > > If no, then we can merge in RC1 if no objection. > [Hemant] > On a high level this series looks good to us. However currently we are in the > process of testing it. > Will you please wait for our ack? Currently we are trying to completed it > before RC1
OK. Will for NXP's Ack. > > Regards, > Hemant >
