On 8/28/2019 12:08 PM, Gagandeep Singh wrote: > This patch introduces logging for the ppfe PMD. > > Signed-off-by: Gagandeep Singh <g.si...@nxp.com> > Acked-by: Nipun Gupta <nipun.gu...@nxp.com> > Acked-by: Akhil Goyal <akhil.go...@nxp.com> > --- > drivers/net/ppfe/pfe_logs.h | 30 ++++++++++++++++ > drivers/net/ppfe/ppfe_ethdev.c | 65 +++++++++++++++++++++++++++------- > 2 files changed, 82 insertions(+), 13 deletions(-) > create mode 100644 drivers/net/ppfe/pfe_logs.h > > diff --git a/drivers/net/ppfe/pfe_logs.h b/drivers/net/ppfe/pfe_logs.h > new file mode 100644 > index 000000000..8b34e8d1e > --- /dev/null > +++ b/drivers/net/ppfe/pfe_logs.h > @@ -0,0 +1,30 @@ > +/* SPDX-License-Identifier: BSD-3-Clause > + * Copyright 2019 NXP > + */ > + > +#ifndef _PFE_LOGS_H_ > +#define _PFE_LOGS_H_ > + > +/* PMD related logs */ > + > +#define PFE_PMD_LOG(level, fmt, args...) \ > + rte_log(RTE_LOG_ ## level, RTE_LOGTYPE_PMD, "%s(): " fmt "\n",\ > + __func__, ##args) > +
Please don't use 'RTE_LOGTYPE_PMD' log type but register a dynamic one for the driver.