> -----Original Message----- > From: Gavin Hu (Arm Technology China) [mailto:gavin...@arm.com] > Sent: Wednesday, September 25, 2019 11:20 AM > To: Cao, Yahui <yahui....@intel.com>; Yang, Qiming > <qiming.y...@intel.com>; Lu, Wenzhuo <wenzhuo...@intel.com> > Cc: dev@dpdk.org; Zhang, Qi Z <qi.z.zh...@intel.com>; Ye, Xiaolong > <xiaolong...@intel.com>; Xing, Beilei <beilei.x...@intel.com>; nd > <n...@arm.com> > Subject: RE: [dpdk-dev] [PATCH v3 1/8] net/ice: enable flow director engine > > Hi Yahui, > > two general comments: > 1.Please make old versions of patches Superseded to facilitate review. > 2. the two occurrences of rte_wmb can be removed, a similar patch has > been reviewed by Qi. http://patches.dpdk.org/patch/59278/
Thanks for the comments, will be updated in v4. Beilei > > /Gavin > > > -----Original Message----- > > From: dev <dev-boun...@dpdk.org> On Behalf Of Yahui Cao > > Sent: Wednesday, September 25, 2019 5:53 AM > > To: Qiming Yang <qiming.y...@intel.com>; Wenzhuo Lu > > <wenzhuo...@intel.com> > > Cc: dev@dpdk.org; Qi Zhang <qi.z.zh...@intel.com>; Xiaolong Ye > > <xiaolong...@intel.com>; Beilei Xing <beilei.x...@intel.com>; Yahui > > Cao <yahui....@intel.com> > > Subject: [dpdk-dev] [PATCH v3 1/8] net/ice: enable flow director > > engine > > > > From: Beilei Xing <beilei.x...@intel.com> > > > > Enable flow director engine, including initialization and teardown. > > - Control VSI create and release. > > - Queue pair allocated, set up and release. > > - Programming packet create and release. > > - FDIR profile create and release. > > > > Signed-off-by: Beilei Xing <beilei.x...@intel.com> > > ---
