On 8/23/2019 2:47 PM, Wei Hu (Xavier) wrote: > This patch adds support for mailbox of hns3 PMD driver, mailbox is > used for communication between PF and VF driver. > > Signed-off-by: Min Hu (Connor) <humi...@huawei.com> > Signed-off-by: Wei Hu (Xavier) <xavier.hu...@huawei.com> > Signed-off-by: Chunsong Feng <fengchuns...@huawei.com> > Signed-off-by: Hao Chen <chenhao...@huawei.com> > Signed-off-by: Huisong Li <lihuis...@huawei.com>
<...> > @@ -27,6 +27,7 @@ > #include <rte_io.h> > > #include "hns3_cmd.h" > +#include "hns3_mbx.h" Why need to include the new header if .c file is not using from the header? Same for other .c files below. <...> > @@ -0,0 +1,337 @@ > +/* SPDX-License-Identifier: BSD-3-Clause > + * Copyright(c) 2018-2019 Hisilicon Limited. > + */ > + > +#include <errno.h> > +#include <stdbool.h> > +#include <stdint.h> > +#include <stdio.h> > +#include <stdlib.h> > +#include <string.h> > +#include <sys/queue.h> > +#include <inttypes.h> > +#include <unistd.h> > +#include <rte_byteorder.h> > +#include <rte_common.h> > +#include <rte_cycles.h> > +#include <rte_debug.h> > +#include <rte_dev.h> > +#include <rte_eal.h> > +#include <rte_ether.h> > +#include <rte_ethdev_driver.h> > +#include <rte_io.h> > +#include <rte_spinlock.h> > +#include <rte_pci.h> > +#include <rte_bus_pci.h> Same comment for all .c files in the driver, above inclusion list feels like a copy/paste, can you please include only necessary headers?
