On 8/23/2019 2:46 PM, Wei Hu (Xavier) wrote: > This patch adds support for cmd of hns3 PMD driver, driver can interact > with firmware through command to complete hardware configuration. > > Signed-off-by: Hao Chen <chenhao...@huawei.com> > Signed-off-by: Wei Hu (Xavier) <xavier.hu...@huawei.com> > Signed-off-by: Chunsong Feng <fengchuns...@huawei.com> > Signed-off-by: Min Hu (Connor) <humi...@huawei.com> > Signed-off-by: Huisong Li <lihuis...@huawei.com>
<...> > diff --git a/drivers/net/hns3/hns3_ethdev.h b/drivers/net/hns3/hns3_ethdev.h > index bfb54f2..84fcf34 100644 > --- a/drivers/net/hns3/hns3_ethdev.h > +++ b/drivers/net/hns3/hns3_ethdev.h > @@ -39,7 +39,6 @@ > > #define HNS3_4_TCS 4 > #define HNS3_8_TCS 8 > -#define HNS3_MAX_TC_NUM 8 This definition is used by 'hns3_ethdev.h' but moved to 'hns3_cmd.h', and 'hns3_ethdev.h' doesn't include 'hns3_cmd.h', which will force whatever .c file include 'hns3_ethdev.h' to include 'hns3_cmd.h' before it and these kind of .h order dependencies are easy to break. Would it work if 'hns3_ethdev.h' includes 'hns3_cmd.h'
