> -----Original Message----- > From: David Marchand [mailto:david.march...@redhat.com] > Sent: Tuesday, August 13, 2019 17:58 > To: Stephen Hemminger <step...@networkplumber.org>; Wang, Haiyue > <haiyue.w...@intel.com> > Cc: dev <dev@dpdk.org>; Neil Horman <nhor...@tuxdriver.com> > Subject: Re: [dpdk-dev] [RFC v2 1/3] ethdev: add the API for getting trace > information > > On Tue, Aug 13, 2019 at 5:24 AM Stephen Hemminger > <step...@networkplumber.org> wrote: > > > > On Tue, 13 Aug 2019 11:06:10 +0800 > > Haiyue Wang <haiyue.w...@intel.com> wrote: > > > > int rte_eth_tx_queue_info_get(uint16_t port_id, uint16_t queue_id, > > > struct rte_eth_txq_info *qinfo); > > > > > > +int > > > +rte_eth_trace_info_get(uint16_t port_id, uint16_t queue_id, > > > + enum rte_eth_trace type, char *buf, int sz); > > > + > > > > You didn't run checkpatch, otherwise you would have seen complaints > > about not listing API as experimental. > > The checks in checkpatches.sh won't catch this. > But trying to build dpdk as a shared library will. > > Example: https://travis-ci.com/david-marchand/dpdk/jobs/224737320 > >
Got it, thanks for sharing, just for a quick RFC, missed something in detail for making an API. > -- > David Marchand
