On Tue, Jul 30, 2019 at 10:17:46AM +0200, Thomas Monjalon wrote: > 05/07/2019 11:39, Thomas Monjalon: > > 05/07/2019 11:38, Thomas Monjalon: > > > 05/07/2019 11:35, Bruce Richardson: > > > > On Fri, Jul 05, 2019 at 10:33:59AM +0100, Bruce Richardson wrote: > > > > > The names of the rawdev drivers and the resultant libraries they built > > > > > were pretty inconsistent. In terms of directory names, some had > > > > > "rawdev" > > > > > in the name, e.g. skeleton_rawdev, ifpga_rawdev, while others didn't. > > > > > Also, for the built .so/.a libraries, the names were not always > > > > > consistent between make and meson, as, while meson enforced a > > > > > consistent > > > > > naming scheme, make did not, leading to differences - especially for > > > > > those drivers with "rawdev" in the directory name. > > > > > > > > > > This patchset attempts to make things more standardized by removing > > > > > "rawdev" from all directory names - the drivers are in the > > > > > "drivers/raw" > > > > > directory after all - and then standardizing the library names to > > > > > "librte_rawdev_<name>" for both make and meson. > > > > > > > > > > Bruce Richardson (2): drivers/raw: remove rawdev from driver directory > > > > > names drivers/raw: standardize name format of rawdev drivers > > > > > > > > > Since the .so/.a files we produce are changing, would this patchset - if > > > > accepted - need a deprecation notice in 19.08 for a future 19.11 merge? > > > > > > I would say we can merge it in 19.08 without prior notice. > > > Any other opinion? > > > > Cc Neil > > We got no more opinion. > Does it mean I can merge it in 19.08-rc3? >
Seems like it should be safe enough to me. Rawdevs are pretty new and not that widely used, I suspect. Any issues that do arise with the rename can be resolved via symlink, so the risk is low, I suspect. Regards, /Bruce
