Hi Shally,
> >
> > Signed-off-by: Arek Kusztal <arkadiuszx.kusz...@intel.com>
> > ---
> > lib/librte_cryptodev/rte_crypto_asym.h | 26
> > +++++++++++++++++++++++++-
> > 1 file changed, 25 insertions(+), 1 deletion(-)
> >
> > diff --git a/lib/librte_cryptodev/rte_crypto_asym.h
> > b/lib/librte_cryptodev/rte_crypto_asym.h
> > index 02ec304..16c86c9 100644
> > --- a/lib/librte_cryptodev/rte_crypto_asym.h
> > +++ b/lib/librte_cryptodev/rte_crypto_asym.h
> > @@ -397,9 +397,33 @@ struct rte_crypto_rsa_op_param {
> > /**<
> > * Pointer to data
> > * - to be encrypted for RSA public encrypt.
> > - * - to be decrypted for RSA private decrypt.
> > * - to be signed for RSA sign generation.
> > * - to be authenticated for RSA sign verification.
> > + *
> > + * Octet-string network byte order format.
> > + *
> > + * This field is an input to RTE_CRYPTO_ASYM_OP_ENCRYPT
> > + * operation, and output to RTE_CRYPTO_ASYM_OP_DECRYPT
> > operation.
> > + *
> > + * When RTE_CRYPTO_ASYM_OP_DECRYPT op_type used length in
> > bytes
> > + * of this field needs to be greater or equal to the length of
> > + * corresponding RSA key in bytes.
> > + */
> [Shally] this overall look repetitive here. Since now this buffer is both
> input
> and output depending on op_type.
> How about , if we just change description to:
> Pointer to plaintext buffer. This buffer is input to
> RSA_CRYPTO_ASYM_OP_TYPE_ENCRYPT/ SIGN, VERIFY And Output to
> RTE_CRYPTO_ASYM_OP_TYPE_DECRYPT
[AK] - I have missed this mail. You right, but instead of sending v5 just for
that I could change this in future patches?
>
> > +
> > +
> > + rte_crypto_param cipher;
> > + /**<
> > + * Pointer to data
> > + * - to be decrypted for RSA private decrypt.
> > + *
> > + * Octet-string network byte order format.
> > + *
> > + * This field is an input to RTE_CRYPTO_ASYM_OP_DECRYPT
> > + * operation, and output to RTE_CRYPTO_ASYM_OP_ENCRYPT
> > operation.
> > + *
> > + * When RTE_CRYPTO_ASYM_OP_ENCRYPT op_type used length in
> > bytes
> > + * of this field needs to be greater or equal to the length of
> > + * corresponding RSA key in bytes.
> > */
> [Shally] So is my suggestion here. Change to like "Pointer to Ciphetext buffer
> ..."
>
> >
> > rte_crypto_param sign;
> > --
> > 2.1.0
