On Wed, Jul 03, 2019 at 11:10:21AM +0200, David Marchand wrote: > > On Wed, Jul 3, 2019 at 11:01 AM Tiwei Bie <tiwei....@intel.com> wrote: > > On Wed, Jul 03, 2019 at 10:26:39AM +0200, David Marchand wrote: > > This patch breaks the ABI by extending rte_pci_device. > > You must rework it to avoid this break. > > I didn't expect it to be merged in this release. I just want > to draw other's attention on this and kick off the discussion > (it would be great if you would like to share your thoughts > on this). If there is a way to avoid extending rte_pci_device, > it would be definitely great. But if we have to break it, then > we would want to send out the announce as early as possible. > > > What we have here is a vfio private thing, we don't need it to be exposed. > > Did not think it through yet. > How about having an internal (as in, in the pci driver code) representation of > the pci devices? > This internal structure would embed the rte_pci_device exposed to the others > subsystems and the applications and the vfio code would just get what it wants > by using offsetof?
I think it's a good idea! I'll give it a try. Thanks! Tiwei > > > -- > David Marchand
