On Mon, Jul 01, 2019 at 09:27:56PM +0100, Chautru, Nicolas wrote: > > >-----Original Message----- > >From: Thomas Monjalon [mailto:tho...@monjalon.net] > >Sent: Monday, July 1, 2019 12:18 PM > >To: Chautru, Nicolas <nicolas.chau...@intel.com> > >Cc: Akhil Goyal <akhil.go...@nxp.com>; dev@dpdk.org; Yigit, Ferruh > ><ferruh.yi...@intel.com>; Mokhtar, Amr <amr.mokh...@intel.com> > >Subject: Re: [PATCH v4 10/10] doc: announce bbdev changes > > > >01/07/2019 20:14, Chautru, Nicolas: > >> > >> >One more thing, if there is a change in ABI, should you also increment > >> >the bbdev ABI version? > >> > >> The bbdev ABI is still marked as __rte_experimental hence I don't believe > >> we have yet to increment it. > > > >ABI version and experimental state are two different things. > >I think we should upgrade the version even for experimental libraries. > > Thanks Thomas. > > Bruce, Ferruh can you comment whether bumping ABI version is required for > __rte_experimental API? Arguably the documentation may be interpreted either > way : https://doc.dpdk.org/guides-18.08/contributing/versioning.html > > In the specific case of bbdev change in that serie, note that only new > operations (for 5GNR signal processing) and related symbols are being added. > Previous releases included BBDEV API changes without updating ABI version > number ( librte_bbdev.so.1). > > Thanks for letting me know, in both cases we may make it more explicit on the > versioning page. > Nic
I think there may be some misunderstanding here, so long as no existing APIs are changed or removed, we don't bump the ABI version. /Bruce
