On Tue, 08 Dec 2015 21:57:33 +0100 Thomas Monjalon <thomas.monjalon at 6wind.com> wrote:
> 2015-12-08 21:55, Jan Viktorin: > > On Tue, 08 Dec 2015 21:30:03 +0100 > > Thomas Monjalon <thomas.monjalon at 6wind.com> wrote: > > > > > 2015-12-08 20:29, Jan Viktorin: > > > > (I considered to not add the cover-letter as this is just a single > > > > small patch. > > > > I hope it does not matter a lot. Is there any convention how to do > > > > this?) > > > > > > The main interest of splitting patches or adding a cover letter it to have > > > a place to explain the changes. When you have several changes, they > > > deserve > > > several patches to provide an accurate explanation. In such case, you may > > > need a cover letter to describe the global idea of the series. A cover > > > letter > > > is also helpful for mail threading and acking all the series. > > > When you have only one change, one email is enough. > > > > That's good. Should there be a way how to separate the "inline-cover" > > and the commit? > > Do you mean how add a comment which won't be in the git tree? > You can put whatever between the 3 dashes and the diff. > Exactly. When I was writing this message, I decided to put the "cover" first and the commit log after the 3 dashes. It was more logical to me...