On 12/07/2015 04:32 PM, Thomas Monjalon wrote: > 2015-12-07 16:09, Panu Matilainen: >> On 12/03/2015 04:05 PM, Panu Matilainen wrote: >>> In addition to git tags, support validating abi between any legal >>> gitrevisions(7) syntaxes, such as "validate-abi.sh -1 . <target>" >>> "validate-abi.sh master mybranch <target>" etc in addition to >>> validating between tags. Makes it easier to run the validator >>> for in-development work. >>> >>> Signed-off-by: Panu Matilainen <pmatilai at redhat.com> >>> Acked-by: Neil Horman <nhorman at tuxdriver.com> >>> --- >>> >>> v2 changes: >>> - update usage and error messages to match new behavior >>> - update documentation too (as suggested by John McNamara) >>> >> >> I started wondering why this didn't get applied along with the other >> abi-validator changes and noticed this is sitting in patchwork in >> "changes requested" state, which doesn't seem right: v2 added the >> requested documentation. > > It seems to be an error. > >> The discussion around this patch did spur another request (ability to >> pass parallel build flags to make) but that's entirely unrelated, so it >> shouldn't hold up this one. > > Yes > >> I've no intention of sending a v3 of this patch because AFAIK there's >> nothing to fix and the make-flags thing does not belong here, but >> resetting the state to "new" by myself feels like cheating or something >> :) So what's the correct action here? There's preciously little >> documentation about expected patchwork workflow and such. > > It's not cheating. > Changing patchwork status and send such an email looks to be the right thing > to do.
Ok, done. Thanks for clarifying. > > Yes maybe we can improve the contributing guide. Perhaps this could be used as a base, or referred to (assuming of course the info is rasonably applicaple to dpdk too)? https://sourceware.org/glibc/wiki/Patch%20Review%20Workflow - Panu - > Thanks >
