On Mon, Dec 07, 2015 at 03:40:13AM -0800, Thomas Monjalon wrote: > 2015-12-07 12:56, Jerin Jacob: > > On Sun, Dec 06, 2015 at 05:30:50PM +0100, Thomas Monjalon wrote: > > > 2015-12-06 21:29, Jerin Jacob: > > > > This patchset fixes performance/cache resource issues with 128-byte > > > > cache line targets > > > > found in mbuf and bitmap DPDK libraries > > > > > > > > Currently, we have two DPDK targets(ThunderX and ppc_64) which are > > > > based on > > > > 128-bytes cache line size target. > > > > > > When introducing IBM Power8, we failed to clean the cache line size > > > definition. > > > I promised to not forget this issue in this thread with Neil: > > > http://dpdk.org/ml/archives/dev/2014-December/009439.html > > > > > > It is defined in > > > config/defconfig_* > > > mk/machine/*/rte.vars.mk > > > mk/arch/*/rte.vars.mk > > > rte_memory.h > > > rte_kni_common.h > > > > > > It should be defined only in the config files. > > > When we will introduce a configure script, we should be able to detect it. > > > > > > Please Jerin, as ThunderX maintainer, may you help to fix this old mess? > > > > Yes Thomas, I will takeup this issue when we will have configure script. > > I thought we could start setting the value in only one place. > The detection in configure script would be another step.
OK Thomas, I have sent the cleanup patch. Please review it. Jerin > > > apart from that, content of the this patch will be still valid > > as the fix going to be generating cache line define from the config file. > >
