Hi John,

Thanks for this patch set, it really makes DPDK documentation more refined.

> -(for example the collectd plugin) should be run to begin querying the
API.
> +(for example the CollectD plugin) should be run to begin querying the
API.


I am not sure about this change to "CollectD". Actually from what I know,
in official
collectd/service assurance documenration, it always appear as "collectd
plugin" or "Collectd plugin" (this is the usual semantics for unix/linux
daemons).

For example,

https://blog.dbrgn.ch/2017/3/10/write-a-collectd-python-plugin/
https://wiki.opnfv.org/display/fastpath/Collectd+how+to+implement+a+simple+plugin
https://collectd.org/documentation/manpages/collectd.conf.5.shtml

If it  agreed that change to CollectD should be reverted, not sure that a
new V3 should be sent, this is a huge patch; if reverting can be done via
merge, it will be better.

Other than that,
Acked-by: Rami Rosen <ramir...@gmail.com>

>
>

Reply via email to