On Wed, 10 Apr 2019 10:32:05 +0200
Olivier Matz <olivier.m...@6wind.com> wrote:
> diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c
> b/drivers/net/bonding/rte_eth_bond_pmd.c
> index f30422a6d..9c5425ef5 100644
> --- a/drivers/net/bonding/rte_eth_bond_pmd.c
> +++ b/drivers/net/bonding/rte_eth_bond_pmd.c
> @@ -489,9 +489,9 @@ uint32_t burstnumberTX;
> #ifdef RTE_LIBRTE_BOND_DEBUG_ALB
>
> static void
> -arp_op_name(uint16_t arp_op, char *buf, size_t buf_len)
> +arp_opcode_name(uint16_t arp_opcode, char *buf, size_t buf_len)
> {
> - switch (arp_op) {
> + switch (arp_opcode) {
> case ARP_OP_REQUEST:
> strlcpy(buf, "ARP Request", buf_len);
> return;
> @@ -566,7 +566,7 @@ update_cli
This is an internal function, why did it have to be renamed?
> diff --git a/drivers/net/i40e/base/i40e_adminq_cmd.h
> b/drivers/net/i40e/base/i40e_adminq_cmd.h
> index cf6ef63e3..f988e74c6 100644
> --- a/drivers/net/i40e/base/i40e_adminq_cmd.h
> +++ b/drivers/net/i40e/base/i40e_adminq_cmd.h
> @@ -458,7 +458,7 @@ struct i40e_aqc_cppm_configuration {
> I40E_CHECK_CMD_LENGTH(i40e_aqc_cppm_configuration);
>
> /* Set ARP Proxy command / response (indirect 0x0104) */
> -struct i40e_aqc_arp_proxy_data {
> +struct i40e_aqc_arp_protocolxy_data {
> __le16 command_flags;
Don't change private data or function names in base code.
