Hello Thomas, Thanks for the review!
On 10.04.2019 14:46, Thomas Monjalon wrote: > 10/04/2019 13:18, Igor Russkikh: >> MACSEC related device ops, API and parameters are taken from the >> existing ixgbe PMD ops > > Please can you explain how it is related to rte_security? It is not. Do you mean macsec control API could be moved and logically be a part of rte_security api? I can't comment now on how feasible is this. Moreover this depends on how Intel considers and uses the existing macsec offload in ixgbe. > The generic API is implemented in ixgbe in next patch. > You should reverse them, or completely move this patch at the end. You are right, I'll swap them. > Please merge such doc update in the patch enabling the feature. Ok, Thanks, Igor
