On Wed, 2 Dec 2015 16:18:13 +0530 Jerin Jacob <jerin.jacob at caviumnetworks.com> wrote:
> > > [snip] > > > > My preference would also be to put architecture dependent implementation > > into different files. > > Might be create lib/librte_lpm/arch/(arm|x86)/... here? > > Konstantin > > +1 > > my existing patch creates lib/librte_lpm/rte_lpm_neon.h instead > of lib/librte_lpm/arch/arm/rte_lpm_neon.h like > lib/librte_hash/rte_cmp_x86.h > > I am OK for changing the directory structure as proposed in my next revision > of patch. > Let me know if anyone has any objections/concerns. > > Jerin I don't like the idea to have arch/... directory structure inside libraries. I would delay such decision until there are really a big number of different optimized implementations. However, the rte_lpm_neon.h approach is OK from my point of view. Jan > > [snip]
