On Tue, Apr 2, 2019 at 11:07 PM Stephen Hemminger < step...@networkplumber.org> wrote:
> On Tue, 2 Apr 2019 23:03:06 +0200 > David Marchand <david.march...@redhat.com> wrote: > > > On Tue, Apr 2, 2019 at 10:48 PM Stephen Hemminger < > > step...@networkplumber.org> wrote: > > > > > On Tue, 2 Apr 2019 22:15:40 +0200 > > > David Marchand <david.march...@redhat.com> wrote: > > > > > Well, I understand this is not clean, but this patch breaks the > API. > > > > > > The lcore state was marked as internal in the header file, code that > > > ignores that is going to have problems. The values are the same. > > > > > > We could defer this to 19.11 (next LTS) since it is cosmetic. > > > > > > > We must announce it before changing. > > I disagree, if an API is marked as internal it can be changed at any > time (as long as ABI is maintained). > rte_launch.h is exposed to applications. And specifically, for rte_eal_get_lcore_state(): /** * Get the state of the lcore identified by slave_id. * * To be executed on the MASTER lcore only. * * @param slave_id * The identifier of the lcore. * @return * The state of the lcore. */ enum rte_lcore_state_t rte_eal_get_lcore_state(unsigned slave_id); I don't see where this is marked as internal. -- David Marchand
