On Tue, 2 Apr 2019 22:15:40 +0200 David Marchand <david.march...@redhat.com> wrote:
> On Tue, Apr 2, 2019 at 5:57 PM Stephen Hemminger <step...@networkplumber.org> > wrote: > > > C language does not really treat enum's as first class symbols. > > The values in an enum live in a global namespace. That means if > > DPDK defines "RUNNING" it can't be used by another enum in an > > application using DPDK. > > > > To solve this add a prefix "RTE_LCORE_" to the enum values, and > > make them grammatically consistent. > > > > Well, I understand this is not clean, but this patch breaks the API. The lcore state was marked as internal in the header file, code that ignores that is going to have problems. The values are the same. We could defer this to 19.11 (next LTS) since it is cosmetic. At that time, I am willing to do more work to make lcore_config hidden; ie no inline's to access it.
