On Tue, 2019-03-19 at 17:22 +0000, Jerin Jacob Kollanukkaran wrote: > From: Jerin Jacob <jer...@marvell.com> > > Remove the following warning by comparing string to string. > > config/arm/meson.build:153: WARNING: Trying to compare values of > different types (list, str) using ==. > > Fixes: c6e536e38437 ("build: add more implementers IDs and PNs for > ARM") > Cc: sta...@dpdk.org > > Signed-off-by: Jerin Jacob <jer...@marvell.com> > --- > > v2: Remove meson version related warning as bumbing the version needs > techboard approval. > > --- > config/arm/meson.build | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/config/arm/meson.build b/config/arm/meson.build > index 8e892fa77..170a4981a 100644 > --- a/config/arm/meson.build > +++ b/config/arm/meson.build > @@ -116,8 +116,8 @@ else > cmd_output = > cmd.stdout().to_lower().strip().split(' ') > endif > # Set to generic if variable is not found > - machine = get_variable('impl_' + cmd_output[0], > 'generic') > - if machine == 'generic' > + machine = get_variable('impl_' + cmd_output[0], > ['generic']) > + if machine[0] == 'generic' > machine = impl_generic > cmd_output = cmd_generic > endif
Acked-by: Luca Boccassi <bl...@debian.org> -- Kind regards, Luca Boccassi