Re: [dpdk-dev] [PATCH 4/4] power: send confirmation cmd to vm guest

[Pattan, Reshma]

> -----Original Message-----
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Hajkowski

> +             int ret = -1;
> +             if (valid_unit)
> +                     ret = send_ack_for_received_cmd(pkt,
> +                                             chan_info,
> +                                             scale_res ?

> CPU_POWER_CMD_ACK : CPU_POWER_CMD_NAK);
> +             if (ret < 0)
> +                     RTE_LOG(DEBUG, CHANNEL_MONITOR, "Error during
> sending ack command "
> +                                     "or unexpected unit type.\n");
> +
>       }

This if check should go inside for if(valid_unit)?,  otherwise this would 
applicable for valid_unit == false also.
Also do we need to handle valid_unit ==false case? Do we need to send back  
message to guest saying invalid command.

Thanks,
Reshma