On Tue, Mar 12, 2019 at 10:42:39AM -0700, Stephen Hemminger wrote:
> On Tue, 12 Mar 2019 15:13:07 +0800
> Tiwei Bie <tiwei....@intel.com> wrote:
>
> > The multiqueue support in virtio-user with vhost kernel backend
> > is broken when tap name isn't specified by users explicitly,
> > because the tap name returned by ioctl(TUNSETIFF) isn't saved
> > properly, and multiple tap interfaces will be created in this
> > case. Fix this by saving the dynamically allocated tap name
> > first before reusing the ifr structure. Besides, also make it
> > possible to support the format string in tap name (e.g. foo%d)
> > specified by users explicitly.
> >
> > Fixes: 791b43e08842 ("net/virtio-user: specify MAC of the tap")
> > Cc: sta...@dpdk.org
> >
> > Reported-by: Stephen Hemminger <step...@networkplumber.org>
> > Signed-off-by: Tiwei Bie <tiwei....@intel.com>
>
> Reviewed-by: Stephen Hemminger <step...@networkplumber.org>
>
> Does this have any impact on primary/secondary support?
No. But I think there are some other issues with virtio-user
on primary/secondary support currently. I plan to send some
fixes for it later.
Thanks,
Tiwei
