01/03/2019 18:08, Michael Santana:
> +# Enable codespell by default. This can be overwritten from a config file.
> +# You can also enable codespell by setting DPDK_CHECKPATCH_CODESPELL to a
> valid path
> +# to a dictionary.txt file if your dictionary.txt is not in the default
> location.
Better to avoid "you" form in such comment.
> +DPDK_CHECKPATCH_CODESPELL=enable
> # Load config options:
> # - DPDK_CHECKPATCH_PATH
> # - DPDK_CHECKPATCH_LINE_LENGTH
> +# - DPDK_CHECKPATCH_CODESPELL
> . $(dirname $(readlink -e $0))/load-devel-config
>
> VALIDATE_NEW_API=$(dirname $(readlink -e $0))/check-symbol-change.sh
> @@ -13,6 +18,12 @@ length=${DPDK_CHECKPATCH_LINE_LENGTH:-80}
>
> # override default Linux options
> options="--no-tree"
> +if [ "$DPDK_CHECKPATCH_CODESPELL" == "enable" ]; then
This is a bashism.
Standard sh uses a simple =
No need for a v4, I can fix it.
