14/02/2019 20:35, Michael Santana: > Enable codespell by default. > codespell is a feature by checkpatch.pl that > checks for common spelling mistakes in patches.
What is the difference between codespell and spelling.txt included with checkpatch? Is it just a different dictionary? > This feature is disabled by default. To enable it one must add > the '--codespell' flag to the $options variable in > checkpatches.sh. We need also to specify the dictionary path if not in /usr/share/codespell/dictionary.txt In my case, it is in /usr/lib/python3.7/site-packages/codespell_lib/data/dictionary.txt > With this change codespell is enabled by default. It seems it is not enabled by default, because we need DPDK_CHECKPATCH_CODESPELL=enable > The user can decide to turn off codespell from a one of the config > files read by checkpatches.sh. [...] > # override default Linux options > options="--no-tree" > +if [ "$DPDK_CHECKPATCH_CODESPELL" == "enable" ]; then What about allowing either "enable" or a path? If it is a path (have some slash), then we can add --codespellfile option. > + options="$options --codespell" > +fi > options="$options --max-line-length=$length" > options="$options --show-types" > options="$options --ignore=LINUX_VERSION_CODE,\ >
