Hi, Ruifeng, I don't have an ARM Platform at hand to test but I gone through the code against a NEON instruction manual, and the logic looks good to me. One small comment is the coding style for switch case, I think it is more common to leave the braces on their own lines.
Otherwise: Acked-by: Yipeng Wang<yipeng1.w...@intel.com> >-----Original Message----- >From: Ruifeng Wang [mailto:ruifeng.w...@arm.com] >Sent: Monday, February 11, 2019 11:01 PM >To: Wang, Yipeng1 <yipeng1.w...@intel.com>; jer...@marvell.com >Cc: dev@dpdk.org; honnappa.nagaraha...@arm.com; gavin...@arm.com; >n...@arm.com; Ruifeng Wang <ruifeng.w...@arm.com> >Subject: [PATCH v2] hash: optimize signature compare by using neon intrinsic > >Implemented signature compare function based on neon intrinsic. >Hash bulk lookup had 3% - 6% performance gain after optimization. > >Signed-off-by: Ruifeng Wang <ruifeng.w...@arm.com> >Reviewed-by: Gavin Hu <gavin...@arm.com>
