25/01/2019 21:30, Bruce Richardson: > On Fri, Jan 25, 2019 at 08:26:38PM +0000, Bruce Richardson wrote: > > The apps for testing are split between the "test" and "app" directories, > > with a not-very-clear distinction between the two (at least to my mind). > > > > Given how the apps are being built, the easiest path to having > > cmdline_test, test-acl and test-pipeline build using meson is to > > consolidate all these apps back into the app folder and use the logic > > there. The bpf folder doesn't contain an actual application, but > > rather example bpf code which can be loaded into testpmd. That is > > possibly best moved to the examples folder, but I'm open to feedback > > on the best place for it. > > > > With these changes, the "test" folder then becomes the location for > > unit tests only. > > > > > > Bruce Richardson (4): > > test/cmdline_test: move to app directory > > test/test-acl: move to app directory > > test/test-pipeline: move to app directory > > test/bpf: move to examples folder > > > > Although these patches are for 19.05, I'm sending them now for some early > review, as I think we need a deprecation notice for this change in 19.02 if > these changes are acceptable to people.
We don't need a deprecation notice, as it is an internal change without any impact for the users. > Therefore, please review and let me know any issues people see with this > change. We should move all test apps into the same directory. Is there any benefit of keeping unit tests separate? It looks more logic to move everything in test/ but it would make the git history of testpmd more complex. The other choice is to move all tests in app/. The other split to discuss is between app/ and usertools/. We could move user-oriented apps to usertools. pdump and proc-info fall into this basket because they can be used for debugging purpose.
