On Jan 9, 2019, at 5:46 AM, David Marchand <[email protected]<mailto:[email protected]>> wrote:
On Wed, Jan 9, 2019 at 2:19 PM Yongseok Koh <[email protected]<mailto:[email protected]>> wrote: This patch introduces two new functions - rte_mbuf_buf_addr_default() and rte_mbuf_data_baddr_default(). rte_mbuf_buf_addr_default() reutrns the default buffer address of given mbuf which comes after mbuf structure and private data. The buffer address should always be the same for a given mbuf, there is no "default" value for it, there is only one value. So for me s/rte_mbuf_buf_addr_default/rte_mbuf_buf_addr/g. +1 rte_mbuf_data_baddr_default() returns the default address of mbuf data taking the headroom into account. Or just rte_mbuf_data_addr_default() ? +1 Signed-off-by: Yongseok Koh <[email protected]<mailto:[email protected]>> Those are new functions, they should go through the EXPERIMENTAL api marking process. If that's the rule, I'll follow anyway, although these are too obvious to be experimental. Thanks, Yongseok
