10/01/2019 15:52, Ananyev, Konstantin: > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > 10/01/2019 15:20, Konstantin Ananyev: > > > v6 -> v7 > > > - Changes to address Thomas comments: > > > bump ABI version > > > remove related deprecation notice > > > update release notes, ABI changes section > > > > You did not update the lib versions in the release notes. > > For 'security: add opaque userdata pointer into security session': > 1) removed deprecation notice > 2) add ABI change into release note: > +* security: New field ``uint64_t opaque_data`` is added into > + ``rte_security_session`` structure. That would allow upper layer to easily > + associate/de-associate some user defined data with the security session. > + > 3) Bumbed version in Makefile and meson.build > > What else needs to be done here?
Like I said, "update the lib versions in the release notes". Please check at the bottom of the page, there is a list of libraries. > > I think you missed a deprecation notice removal in patch 1. > As Pablo noticed that would happen in "cryptodev: update symmetric session", > this patch will be just dropped from the series. OK > > Have you checked the doxygen warnings in last patch? > I think I fixed that in v7, are still seeing them? OK I did not check. It was just a question because it is not in the changelog.
