04/01/2019 10:29, Ananyev, Konstantin: > > > -----Original Message----- > > From: Stephen Hemminger [mailto:step...@networkplumber.org] > > Sent: Friday, January 4, 2019 12:26 AM > > To: Ananyev, Konstantin <konstantin.anan...@intel.com> > > Cc: dev@dpdk.org; akhil.go...@nxp.com > > Subject: Re: [dpdk-dev] [PATCH v6 01/10] cryptodev: add opaque userdata > > pointer into crypto sym session > > > > On Thu, 3 Jan 2019 20:16:17 +0000 > > Konstantin Ananyev <konstantin.anan...@intel.com> wrote: > > > > > Add 'uint64_t opaque_data' inside struct rte_cryptodev_sym_session. > > > That allows upper layer to easily associate some user defined > > > data with the session. > > > > > > Signed-off-by: Konstantin Ananyev <konstantin.anan...@intel.com> > > > Acked-by: Fiona Trahe <fiona.tr...@intel.com> > > > Acked-by: Mohammad Abdul Awal <mohammad.abdul.a...@intel.com> > > > Acked-by: Declan Doherty <declan.dohe...@intel.com> > > > Acked-by: Akhil Goyal <akhil.go...@nxp.com> > > > --- > > > lib/librte_cryptodev/rte_cryptodev.h | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/lib/librte_cryptodev/rte_cryptodev.h > > > b/lib/librte_cryptodev/rte_cryptodev.h > > > index 4099823f1..009860e7b 100644 > > > --- a/lib/librte_cryptodev/rte_cryptodev.h > > > +++ b/lib/librte_cryptodev/rte_cryptodev.h > > > @@ -954,6 +954,8 @@ rte_cryptodev_enqueue_burst(uint8_t dev_id, uint16_t > > > qp_id, > > > * has a fixed algo, key, op-type, digest_len etc. > > > */ > > > struct rte_cryptodev_sym_session { > > > + uint64_t opaque_data; > > > + /**< Opaque user defined data */ > > > __extension__ void *sess_private_data[0]; > > > /**< Private symmetric session material */ > > > }; > > > > This will cause ABI breakage. > > Yes, it surely would. > That's why we submitted deprecation notice in 18.11 and got 3 acks for it.
So you should remove the deprecation notice in this patch, and bump the ABI version, and update the release notes for ABI + version changes.
