Hi,
Every counter that is created (shared or not) is added to the counters list
Therefore every counter destined for removal (i.e. ref_count == 0) should also
be
Removed from this list.
What am I missing ?
Moti
> -----Original Message-----
> From: Slava Ovsiienko
> Sent: Saturday, December 29, 2018 10:13 PM
> To: Mordechay Haimovsky <mo...@mellanox.com>; dev@dpdk.org
> Cc: Mordechay Haimovsky <mo...@mellanox.com>; sta...@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH v2 1/3] net/mlx5: fix shared counter
> allocation logic
>
> Moti, don't you forget to update flow_verbs_counter_release() ?
> Only shared counters should be removed from the list.
>
> WBR,
> Slava
>
> > -----Original Message-----
> > From: dev <dev-boun...@dpdk.org> On Behalf Of Mordechay Haimovsky
> > Sent: Friday, December 28, 2018 0:20
> > To: dev@dpdk.org
> > Cc: Mordechay Haimovsky <mo...@mellanox.com>; sta...@dpdk.org
> > Subject: [dpdk-dev] [PATCH v2 1/3] net/mlx5: fix shared counter
> > allocation logic
> >
> > This commit fixes the logic for searching and allocating a shared
> > counter in mlx5_flow_verbs.
> > Now only the shared counters in the counters list are checked for a
> > match and not all the counters as before.
> >
> > Fixes: 84c406e74524 ("net/mlx5: add flow translate function")
> > Cc: sta...@dpdk.org
> >
> > Signed-off-by: Moti Haimovsky <mo...@mellanox.com>
> > ---
> > v2:
> > * Modified commit header
> > ---
> > drivers/net/mlx5/mlx5_flow_verbs.c | 14 +++++++-------
> > 1 file changed, 7 insertions(+), 7 deletions(-)
> >
> > diff --git a/drivers/net/mlx5/mlx5_flow_verbs.c
> > b/drivers/net/mlx5/mlx5_flow_verbs.c
> > index 81ec59d..409e1cd 100644
> > --- a/drivers/net/mlx5/mlx5_flow_verbs.c
> > +++ b/drivers/net/mlx5/mlx5_flow_verbs.c
> > @@ -121,13 +121,13 @@
> > struct mlx5_flow_counter *cnt;
> > int ret;
> >
> > - LIST_FOREACH(cnt, &priv->flow_counters, next) {
> > - if (!cnt->shared || cnt->shared != shared)
> > - continue;
> > - if (cnt->id != id)
> > - continue;
> > - cnt->ref_cnt++;
> > - return cnt;
> > + if (shared) {
> > + LIST_FOREACH(cnt, &priv->flow_counters, next) {
> > + if (cnt->shared && cnt->id == id) {
> > + cnt->ref_cnt++;
> > + return cnt;
> > + }
> > + }
> > }
> > cnt = rte_calloc(__func__, 1, sizeof(*cnt), 0);
> > if (!cnt) {
> > --
> > 1.8.3.1
