> -----Original Message----- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Monday, December 24, 2018 1:50 PM > To: Ananyev, Konstantin <konstantin.anan...@intel.com>; dev@dpdk.org > Cc: Nicolau, Radu <radu.nico...@intel.com>; Awal, Mohammad Abdul > <mohammad.abdul.a...@intel.com>; Iremonger, Bernard > <bernard.iremon...@intel.com> > Subject: Re: [dpdk-dev] [PATCH v4 6/9] examples/ipsec-secgw: make app to use > ipsec library > > > > On 12/24/2018 6:51 PM, Ananyev, Konstantin wrote: > > > >> -----Original Message----- > >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ananyev, Konstantin > >> Sent: Monday, December 24, 2018 12:37 PM > >> To: Akhil Goyal <akhil.go...@nxp.com>; dev@dpdk.org > >> Cc: Nicolau, Radu <radu.nico...@intel.com>; Awal, Mohammad Abdul > >> <mohammad.abdul.a...@intel.com>; Iremonger, Bernard > >> <bernard.iremon...@intel.com> > >> Subject: Re: [dpdk-dev] [PATCH v4 6/9] examples/ipsec-secgw: make app to > >> use ipsec library > >> > >> > >> > >>> -----Original Message----- > >>> From: Akhil Goyal [mailto:akhil.go...@nxp.com] > >>> Sent: Monday, December 24, 2018 12:33 PM > >>> To: Ananyev, Konstantin <konstantin.anan...@intel.com>; dev@dpdk.org > >>> Cc: Nicolau, Radu <radu.nico...@intel.com>; Awal, Mohammad Abdul > >>> <mohammad.abdul.a...@intel.com>; Iremonger, Bernard > >>> <bernard.iremon...@intel.com> > >>> Subject: Re: [dpdk-dev] [PATCH v4 6/9] examples/ipsec-secgw: make app to > >>> use ipsec library > >>> > >>> > >>> > >>> On 12/24/2018 5:59 PM, Ananyev, Konstantin wrote: > >>>>>> diff --git a/examples/ipsec-secgw/meson.build > >>>>>> b/examples/ipsec-secgw/meson.build > >>>>>> index 77d8b298f..31f68fee2 100644 > >>>>>> --- a/examples/ipsec-secgw/meson.build > >>>>>> +++ b/examples/ipsec-secgw/meson.build > >>>>>> @@ -6,7 +6,7 @@ > >>>>>> # To build this example as a standalone application with an > >>>>>> already-installed > >>>>>> # DPDK instance, use 'make' > >>>>>> > >>>>>> -deps += ['security', 'lpm', 'acl', 'hash'] > >>>>>> +deps += ['security', 'lpm', 'acl', 'hash', 'ipsec'] > >>>>>> allow_experimental_apis = true > >>>>>> sources = files( > >>>>>> 'esp.c', 'ipsec.c', 'ipsec-secgw.c', 'parser.c', > >>>>>> > >>>>> Makefile should also be updated I guess. > >>>> Anything particular you think is missed? > >>> Will it compile with makefile when IPSEC lib is disabled? > >> Nope, it wouldn't. > >> > > Could you be more specific and describe what particular > > changes in the Makefile you think are necessary? > > Is it a check that librte_ipsec was enabled, like one you have for > > rte_security: > > ifneq ($(CONFIG_RTE_LIBRTE_SECURITY),y) > > $(error "RTE_LIBRTE_SECURITY is required to build ipsec-secgw") > > endif > > ? > yes > > Something else? > > BTW, why this check above is needed? > To ensure that user do not compile ipsec-secgw without ipsec/security lib
ipsec-secgw depends on a lot of other libs (cryptodev, ethdev, acl, lpm, etc.). Why only these 2 dependencies require a special check?
