Hi Akhil, > -----Original Message----- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Friday, December 14, 2018 3:23 PM > To: Kusztal, ArkadiuszX <arkadiuszx.kusz...@intel.com> > Cc: dev@dpdk.org; Trahe, Fiona <fiona.tr...@intel.com>; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 2/3] crypto/qat: fix message for CCM when > setting unused counter > > > > On 12/13/2018 1:29 AM, Arek Kusztal wrote: > > AES-CCM algo does not to set counter flag so it should be zeroed. > > > > Fixes: ab56c4d9ed9a ("crypto/qat: support AES-CCM") > > Cc: sta...@dpdk.org > > > > Signed-off-by: Arek Kusztal <arkadiuszx.kusz...@intel.com> > > --- > > drivers/crypto/qat/qat_sym_session.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/crypto/qat/qat_sym_session.c > b/drivers/crypto/qat/qat_sym_session.c > > index 272177f..d8cc702 100644 > > --- a/drivers/crypto/qat/qat_sym_session.c > > +++ b/drivers/crypto/qat/qat_sym_session.c > > @@ -1488,6 +1488,7 @@ int > qat_sym_session_aead_create_cd_auth(struct qat_sym_session *cdesc, > > || cdesc->qat_hash_alg == > ICP_QAT_HW_AUTH_ALGO_KASUMI_F9 > > || cdesc->qat_hash_alg == > ICP_QAT_HW_AUTH_ALGO_ZUC_3G_128_EIA3 > > || cdesc->qat_hash_alg == > ICP_QAT_HW_AUTH_ALGO_AES_XCBC_MAC > > + || cdesc->qat_hash_alg == > ICP_QAT_HW_AUTH_ALGO_AES_CBC_MAC > > ) > > hash->auth_counter.counter = 0; > > else { > title and code change do not match. > AES-CCM or AES-CBC??
CCM is AEAD mode where Counter for cipher and CBC-MAC for hash is used. Hence CBC-MAC for hash. Ref. RFC 3610, SP800-38C. Thanks, Arek
