Re: [dpdk-dev] [PATCH v3 1/2] ring: synchronize the load and store of the tail

[Gavin Hu (Arm Technology China)]

> -----Original Message-----
> From: Stephen Hemminger <step...@networkplumber.org>
> Sent: Thursday, November 1, 2018 6:08 AM
> To: Gavin Hu (Arm Technology China) <gavin...@arm.com>
> Cc: dev@dpdk.org; tho...@monjalon.net; olivier.m...@6wind.com;
> chao...@linux.vnet.ibm.com; bruce.richard...@intel.com;
> konstantin.anan...@intel.com; jerin.ja...@caviumnetworks.com;
> Honnappa Nagarahalli <honnappa.nagaraha...@arm.com>; sta...@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v3 1/2] ring: synchronize the load and store
> of the tail
>
> On Wed, 31 Oct 2018 18:26:26 +0800
> Gavin Hu <gavin...@arm.com> wrote:
>
> > -/*
> > - *  The subtraction is done between two unsigned 32bits
> value
> > +/* load-acquire synchronize with store-release of ht->tail
> > + * in update_tail.
> > + */
> > +const uint32_t cons_tail
>
> Please don't mix declarations and code. Although it is sometimes used in
> DPDK, in general the style is to have declarations at the start of the block
> scope.

Thanks for review, your comment was address in v4.
IMPORTANT NOTICE: The contents of this email and any attachments are 
confidential and may also be privileged. If you are not the intended recipient, 
please notify the sender immediately and do not disclose the contents to any 
other person, use it for any purpose, or store or copy the information in any 
medium. Thank you.