On Fri, 2018-10-12 at 15:09 +0100, Bruce Richardson wrote: > On Thu, Oct 11, 2018 at 08:46:29PM +0100, Luca Boccassi wrote: > > A Kbuild is also included to allow users to use DKMS natively > > without > > additional code. > > > > Signed-off-by: Luca Boccassi <bl...@debian.org> > > --- > > build-tested on debian sid am64 > > > > kernel/linux/kni/Kbuild | 8 ++++++ > > kernel/linux/kni/meson.build | 51 > > ++++++++++++++++++++++++++++++++++++ > > kernel/linux/meson.build | 2 +- > > 3 files changed, 60 insertions(+), 1 deletion(-) > > create mode 100644 kernel/linux/kni/Kbuild > > create mode 100644 kernel/linux/kni/meson.build > > > > I get a couple of errors building this on Fedora 28. First problem is > that > I get a compilation error for a missing rte_fifo.h. The fix for that > error > is to ensure the current dir is on the include list: > > ' -I' + meson.build_root() + > + ' -I' + meson.current_source_dir() + > ' -I' + meson.current_source_dir() + '/ethtool/ixgbe' > + > > Then I hit a second error, where the compile fails because the output > directory for the ethdev files does not exist. > > Fatal error: can't create /home/bruce/dpdk-clean/build-gcc- > static/kernel/linux/kni/ethtool/ixgbe/ixgbe_ethtool.o: No such file > or directory > make[1]: *** [scripts/Makefile.build:318: /home/bruce/dpdk- > clean/build-gcc- > static/kernel/linux/kni/ethtool/ixgbe/ixgbe_ethtool.o] Error 2 > > I haven't fixed this, but I think the easiest fix is probably to > split the > file lists so that each file is listed in a meson.build in its own > subdirectory. Then using subdir to build up the file list rather than > having it all at one gom should cause meson to create the > subdirectory > structure in the build directory. > There may be other, better solutions, though. > > /Bruce
Hi, Interesting, I guess it's down to differences between the kernel makefiles in Debian and Fedora? Although the include one is strange. I've sent a v2 with your suggestions, please give it a run when you've got a sec. -- Kind regards, Luca Boccassi
