> -----Original Message-----
> From: Ori Kam
> Sent: Tuesday, October 23, 2018 9:06 PM
> To: Dekel Peled <[email protected]>; [email protected];
> [email protected]; [email protected];
> [email protected]; Adrien Mazarguil <[email protected]>;
> Thomas Monjalon <[email protected]>; [email protected];
> [email protected]
> Cc: Shahaf Shuler <[email protected]>; [email protected]; Dekel Peled
> <[email protected]>
> Subject: RE: [dpdk-dev] [PATCH 2/2] ethdev: fix metadata documentation
>
>
>
> > -----Original Message-----
> > From: dev <[email protected]> On Behalf Of Dekel Peled
> > Sent: Tuesday, October 23, 2018 4:29 PM
> > To: [email protected]; [email protected];
> > [email protected]; [email protected]; Adrien Mazarguil
> > <[email protected]>; Thomas Monjalon
> <[email protected]>;
> > [email protected]; [email protected]
> > Cc: Shahaf Shuler <[email protected]>; [email protected]; Ori Kam
> > <[email protected]>; Dekel Peled <[email protected]>
> > Subject: [dpdk-dev] [PATCH 2/2] ethdev: fix metadata documentation
> >
> > Previous patch introduced the Tx metadata feature, with unnecessary
> > restrictions on data entry.
> >
> > This fix updates the documentation, removing the data entry
> > restrictions on metadata item.
> >
> > Fixes: aa0b9484eb5f ("ethdev: support metadata as flow rule criteria")
> > Cc: [email protected]
> >
> > Signed-off-by: Dekel Peled <[email protected]>
> > ---
> > doc/guides/prog_guide/rte_flow.rst | 20 ++++++++++----------
> > 1 file changed, 10 insertions(+), 10 deletions(-)
> >
> > diff --git a/doc/guides/prog_guide/rte_flow.rst
> > b/doc/guides/prog_guide/rte_flow.rst
> > index 6fb0535..d6683e4 100644
> > --- a/doc/guides/prog_guide/rte_flow.rst
> > +++ b/doc/guides/prog_guide/rte_flow.rst
> > @@ -1196,21 +1196,21 @@ Item: ``META``
> >
> > Matches an application specific 32 bit metadata item.
> >
> > -- Default ``mask`` matches the specified metadata value.
> > +- Default ``mask`` matches any 32 bit value.
> >
> Are you sure from the impelmetion it looks like default mask is all ones, This
> means that the first comment is the correct one.
>
Right, will change it.
> > .. _table_rte_flow_item_meta:
> >
> > .. table:: META
> >
> > - +----------+----------+-----------------------+
> > - | Field | Subfield | Value |
> > - +==========+==========+=======================+
> > - | ``spec`` | ``data`` | 32 bit metadata value |
> > - +----------+----------------------------------+
> > - | ``last`` | ``data`` | ignored |
> > - +----------+----------+-----------------------+
> > - | ``mask`` | ``data`` | ignored |
> > - +----------+----------+-----------------------+
> > + +----------+----------+---------------------------------------+
> > + | Field | Subfield | Value |
> > +
> >
> +==========+==========+===================================
> ====+
> > + | ``spec`` | ``data`` | 32 bit metadata value |
> > + +----------+--------------------------------------------------+
> > + | ``last`` | ``data`` | upper range value |
> > + +----------+----------+---------------------------------------+
> > + | ``mask`` | ``data`` | bit-mask applies to "spec" and "last" |
> > + +----------+----------+---------------------------------------+
> >
> > Actions
> > ~~~~~~~
> > --
> > 1.8.3.1
