Hi Thomas > -----Original Message----- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Thursday, October 18, 2018 12:29 PM > To: Iremonger, Bernard <bernard.iremon...@intel.com> > Cc: dev@dpdk.org; Yigit, Ferruh <ferruh.yi...@intel.com>; > arybche...@solarflare.com; ophi...@mellanox.com; > rahul.lakkire...@chelsio.com; Wisam Jaddo <wis...@mellanox.com> > Subject: Re: [dpdk-dev] [PATCH v5 1/6] app/testpmd: fix ports list after > removing several at once > > 18/10/2018 12:40, Iremonger, Bernard: > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > > > > From: Wisam Jaddo <wis...@mellanox.com> > > > > > > When detaching a port, the full rte_device is removed. > > > If the rte_device was hosting several ports, the testpmd list of > > > ports must be updated for multiple removals. > > > > ./devtools/check-git-log.sh -1 > > Missing 'Fixes' tag: > > app/testpmd: fix ports list after removing several at once > > I think it is OK. > It is fixing a case which was not tested before. > And we don't really need to backport it.
If "fix" is removed from the commit message then the fixes line will not be needed. However if it is a real fix, then I think fixes line should be added . > > > > Signed-off-by: Wisam Jaddo <wis...@mellanox.com> <snip> Regards, Bernard.
