Hi Thomas, > -----Original Message----- > From: Andrew Rybchenko [mailto:arybche...@solarflare.com] > Sent: Thursday, October 18, 2018 8:45 AM > To: Thomas Monjalon <tho...@monjalon.net>; Yigit, Ferruh > <ferruh.yi...@intel.com> > Cc: dev@dpdk.org; ophi...@mellanox.com; Iremonger, Bernard > <bernard.iremon...@intel.com>; rahul.lakkire...@chelsio.com > Subject: Re: [PATCH v5 2/6] app/testpmd: allow detaching a port not closed > > On 10/18/18 4:23 AM, Thomas Monjalon wrote: > > The testpmd application aim is for testing; so order of operations > > should not be enforced. > > > > There was a test to forbid detaching before closing a port. > > However, it may interesting to test what happens in such case. > > It is possible for a PMD to automatically close the port when detaching. > > Yes. In the case of net/sfc it requires a patch to call sfc_dev_close() from > uninit. > I think network PMD maintainers should be notified to double-check drivers. > > > in order to avoid a crash, it is checked that the port must be stopped > > before detaching (as for closing). > > I thought that it is sufficient to stop traffic and the port may be stopped > automatically by PMD. Not sure about it, just would like to clarify my > previous > notes. > > > Signed-off-by: Thomas Monjalon <tho...@monjalon.net> > > [...]
This patch seems too risky as it may impact some of the PMD's. Regards, Bernard.
