The function rte_eth_dev_detach() is freeing a port and its underlying
rte_device object. The issue is that we may have several ports
associated to the same rte_device.
The right replacement is to free the port, and free the rte_device
if no more ports.
At ethdev level, the public function for port freeing is rte_eth_dev_close().
The only miss is rte_eth_dev_release_port() to free all port resources.
This patchset does a cleanup by moving as much ethdev data freeing
as possible in an unique function rte_eth_dev_release_port(),
and call this function in rte_eth_dev_close().
Changes in v4:
- do not free data fields which are not dynamically allocated blocks
- remove rte_eth_dev_release_port_secondary()
- remove testpmd check to detach without closing
Changes in v3:
- free queues, MAC addresses and private structure
in rte_eth_dev_release_port.
Note: this patchset depends on multi-process hotplug series by Qi Zhang,
which is accepted but waiting for an unrelated DPAA compilation issue
to be fixed, before landing on master tree.
Thomas Monjalon (4):
app/testpmd: allow detaching a port not closed
ethdev: free all common data when releasing port
ethdev: remove release function for secondary process
ethdev: complete closing of port
app/test-pmd/testpmd.c | 22 ++---------
drivers/net/af_packet/rte_eth_af_packet.c | 11 ++++--
drivers/net/ark/ark_ethdev.c | 1 -
drivers/net/avf/avf_ethdev.c | 3 --
drivers/net/avp/avp_ethdev.c | 5 ---
drivers/net/axgbe/axgbe_ethdev.c | 3 --
drivers/net/bnxt/bnxt_ethdev.c | 8 ----
drivers/net/bonding/rte_eth_bond_pmd.c | 9 +----
drivers/net/cxgbe/cxgbe_main.c | 16 +-------
drivers/net/cxgbe/cxgbevf_main.c | 9 +----
drivers/net/dpaa/dpaa_ethdev.c | 10 -----
drivers/net/dpaa2/dpaa2_ethdev.c | 10 -----
drivers/net/e1000/em_ethdev.c | 3 --
drivers/net/e1000/igb_ethdev.c | 6 ---
drivers/net/enetc/enetc_ethdev.c | 4 +-
drivers/net/failsafe/failsafe.c | 6 ++-
drivers/net/failsafe/failsafe_ops.c | 2 +
drivers/net/fm10k/fm10k_ethdev.c | 8 ----
drivers/net/i40e/i40e_ethdev.c | 3 --
drivers/net/i40e/i40e_ethdev_vf.c | 3 --
drivers/net/i40e/i40e_vf_representor.c | 5 ++-
drivers/net/ixgbe/ixgbe_ethdev.c | 9 -----
drivers/net/ixgbe/ixgbe_vf_representor.c | 5 ++-
drivers/net/kni/rte_eth_kni.c | 7 ++--
drivers/net/liquidio/lio_ethdev.c | 3 --
drivers/net/mlx4/mlx4.c | 7 +++-
drivers/net/mlx5/mlx5.c | 11 ++++--
drivers/net/mvneta/mvneta_ethdev.c | 16 +++-----
drivers/net/mvpp2/mrvl_ethdev.c | 16 +++-----
drivers/net/netvsc/hn_ethdev.c | 20 +++-------
drivers/net/null/rte_eth_null.c | 7 +---
drivers/net/octeontx/octeontx_ethdev.c | 31 ++++++----------
drivers/net/pcap/rte_eth_pcap.c | 16 ++++----
drivers/net/qede/qede_ethdev.c | 5 ---
drivers/net/ring/rte_eth_ring.c | 6 +--
drivers/net/sfc/sfc_ethdev.c | 3 --
drivers/net/softnic/rte_eth_softnic.c | 10 ++---
drivers/net/szedata2/rte_eth_szedata2.c | 1 -
drivers/net/tap/rte_eth_tap.c | 11 +++++-
drivers/net/vhost/rte_eth_vhost.c | 15 ++------
drivers/net/virtio/virtio_ethdev.c | 3 --
drivers/net/virtio/virtio_user_ethdev.c | 3 --
drivers/net/vmxnet3/vmxnet3_ethdev.c | 3 --
lib/librte_ethdev/rte_ethdev.c | 45 +++++++----------------
lib/librte_ethdev/rte_ethdev.h | 3 +-
lib/librte_ethdev/rte_ethdev_driver.h | 25 +++++--------
lib/librte_ethdev/rte_ethdev_pci.h | 17 ---------
lib/librte_ethdev/rte_ethdev_version.map | 7 ----
48 files changed, 129 insertions(+), 323 deletions(-)
--
2.19.0
