Hi Feruh, > -----Original Message----- > From: Yigit, Ferruh > Sent: Thursday, October 11, 2018 4:00 PM > To: Raslan Darawsheh <rasl...@mellanox.com>; Wu, Jingjing > <jingjing...@intel.com> > Cc: Thomas Monjalon <tho...@monjalon.net>; dev@dpdk.org; Shahaf Shuler > <shah...@mellanox.com>; Xueming(Steven) Li <xuemi...@mellanox.com>; Ori > Kam <or...@mellanox.com>; jerin.ja...@caviumnetworks.com; > david.march...@6wind.com; Iremonger, Bernard > <bernard.iremon...@intel.com> > Subject: Re: [dpdk-dev] [PATCH v4 3/3] app/testpmd: set packet dump based on > verbosity level > > On 10/7/2018 8:38 AM, Raslan Darawsheh wrote: > > when changing verbosity level it will configure rx/tx callbacks to > > dump packets based on the verbosity value as following: > > 1- dump only received packets: > > testpmd> set verbose 1 > > 2- dump only sent packets: > > testpmd> set verbose 2 > > 3- dump sent and received packets: > > testpmd> set verbose (any number > 2) > > 4- disable dump > > testpmd> set verbose 0 > > It is good to able to enable Rx/Tx separately but you are overloading > "verbose" > meaning here. "verbose" is kind of log_level internal to testpmd and can be > used > by many testpmd debug log. > > Why not create a separate setting for it, perhaps like pkt_verbose?
The original code in rxonly.c used the verbose level, I don't think it is good idea to add a new pkt_verbose. Users will be expecting it to work as before. Regards, Bernard.
