On 10/1/2018 10:26 AM, Andrzej Ostruszka wrote:
> From: Zyta Szpak <z...@semihalf.com>
>
> Add neta pmd driver skeleton providing base for the further
> development.
>
> Signed-off-by: Natalie Samsonov <nsams...@marvell.com>
> Signed-off-by: Yelena Krivosheev <yel...@marvell.com>
> Signed-off-by: Dmitri Epshtein <d...@marvell.com>
> Signed-off-by: Zyta Szpak <z...@semihalf.com>
> Signed-off-by: Andrzej Ostruszka <a...@semihalf.com>
> ---
> MAINTAINERS | 8 +
> config/common_base | 5 +
> devtools/test-build.sh | 2 +
> doc/guides/nics/features/mvneta.ini | 11 +
> doc/guides/nics/mvneta.rst | 152 +++++++
dpdk/doc/guides/nics/mvneta.rst: WARNING: document isn't included in any toctree
Please add document to doc/guides/nics/index.rst
<...>
> +Config File Options
> +-------------------
> +
> +The following options can be modified in the ``config`` file.
> +
> +- ``CONFIG_RTE_LIBRTE_MVNETA_PMD`` (default ``n``)
> +
> + Toggle compilation of the librte_pmd_mvneta driver.
> +
Good to have another section to document "Runtime options" (iface)
> +
> +Usage example
> +^^^^^^^^^^^^^
> +
> +.. code-block:: console
> +
> + ./testpmd --vdev=net_mvneta,iface=eth0,iface=eth1 \
> + -c 3 -- -i --p 3 -a
> +
> +
> +Building DPDK
> +-------------
> +
> +Driver needs precompiled MUSDK library during compilation.
> +
> +.. code-block:: console
> +
> + export CROSS_COMPILE=<toolchain>/bin/aarch64-linux-gnu-
> + ./bootstrap
> + ./configure --host=aarch64-linux-gnu --enable-bpool-dma=64
getting "configure: WARNING: unrecognized options: --enable-bpool-dma"
Is this config option still valid for 18.09?
<...>
> +
> +static int mvneta_dev_num;
> +static int mvneta_lcore_first;
> +static int mvneta_lcore_last;
These static variables seems assigned but not used, can you please check?
<...>
> +
> +RTE_PMD_REGISTER_VDEV(net_mvneta, pmd_mvneta_drv);
Need to document supported devargs with RTE_PMD_REGISTER_PARAM_STRING
<...>
> +struct mvneta_priv {
> + /* Hot fields, used in fast path. */
> + struct neta_ppio *ppio; /**< Port handler pointer */
> +
> + uint8_t pp_id;
> + uint8_t ppio_id; /* ppio port id */
> + uint8_t uc_mc_flushed;
> + uint8_t multiseg;
> +
> + struct neta_ppio_params ppio_params;
> + uint16_t nb_rx_queues;
Do you need this private variable, isn't it duplicate of
"dev->data->nb_rx_queues"?
And as far as I can see "dev->data->nb_rx_queues" one used.
