> 
> Enable print_key_info() function compilation always.
> 
> Fixes: af75078fece36 ("first public release")
> Cc: sta...@dpdk.org
> 
> Suggested-by: Honnappa Nagarahalli <honnappa.nagaraha...@arm.com>
> Signed-off-by: Dharmik Thakkar <dharmik.thak...@arm.com>
> Reviewed-by: Honnappa Nagarahalli <honnappa.nagaraha...@arm.com>
> Reviewed-by: Gavin Hu <gavin...@arm.com>
> ---
> v2:
> * Fix checkpatch coding style issue
> * Add "Fixes:" tag
> ---
>  test/test/test_hash.c | 24 +++++++++---------------
>  1 file changed, 9 insertions(+), 15 deletions(-)
> 
> diff --git a/test/test/test_hash.c b/test/test/test_hash.c index
> b3db9fd10547..db6442a2b101 100644
> --- a/test/test/test_hash.c
> +++ b/test/test/test_hash.c
> @@ -80,29 +80,23 @@ static uint32_t pseudo_hash(__attribute__((unused))
> const void *keys,
>       return 3;
>  }
> 
> +#define UNIT_TEST_HASH_VERBOSE       0
>  /*
>   * Print out result of unit test hash operation.
>   */
> -#if defined(UNIT_TEST_HASH_VERBOSE)
>  static void print_key_info(const char *msg, const struct flow_key *key,
>                                                               int32_t pos)
>  {
> -     uint8_t *p = (uint8_t *)key;
> -     unsigned i;
> -
> -     printf("%s key:0x", msg);
> -     for (i = 0; i < sizeof(struct flow_key); i++) {
> -             printf("%02X", p[i]);
> +     if (UNIT_TEST_HASH_VERBOSE) {
> +             const uint8_t *p = (const uint8_t *)key;
> +             unsigned int i;
> +
> +             printf("%s key:0x", msg);
> +             for (i = 0; i < sizeof(struct flow_key); i++)
> +                     printf("%02X", p[i]);
> +             printf(" @ pos %d\n", pos);
>       }
> -     printf(" @ pos %d\n", pos);
> -}
> -#else
> -static void print_key_info(__attribute__((unused)) const char *msg,
> -             __attribute__((unused)) const struct flow_key *key,
> -             __attribute__((unused)) int32_t pos)
> -{
>  }
> -#endif
> 
>  /* Keys used by unit test functions */
>  static struct flow_key keys[5] = { {
> --
> 2.7.4
Acked-by: Honnappa Nagarahalli <honnappa.nagaraha...@arm.com>

Reply via email to