On Thu, Aug 30, 2018 at 03:46:17PM +0100, Bruce Richardson wrote:
> On Wed, Aug 29, 2018 at 03:48:17PM +0200, Nelio Laranjeiro wrote:
> > Compile Mellanox drivers when their external dependencies are met. A
> > glue version of the driver can still be requested by using the
> > -Denable_driver_mlx_glue=true
> >
> > To avoid modifying the whole sources and keep the compatibility with
> > current build systems (e.g. make), the mlx{4,5}_autoconf.h is still
> > generated by invoking DPDK scripts though meson's run_command() instead
> > of using has_types, has_members, ... commands.
> >
> > Meson will try to find the required external libraries. When they are
> > not installed system wide, they can be provided though CFLAGS, LDFLAGS
> > and LD_LIBRARY_PATH environment variables, example (considering
> > RDMA-Core is installed in /tmp/rdma-core):
> >
> > # CLFAGS=-I/tmp/rdma-core/build/include \
> > LDFLAGS=-L/tmp/rdma-core/build/lib \
> > LD_LIBRARY_PATH=/tmp/rdma-core/build/lib \
> > meson output
> > # LD_LIBRARY_PATH=/tmp/rdma-core/build/lib \
> > ninja -C output install
> >
> > Note: LD_LIBRARY_PATH before ninja is necessary when the meson
> > configuration has changed (e.g. meson configure has been called), in
> > such situation the LD_LIBRARY_PATH is necessary to invoke the
> > autoconfiguration script.
> >
> > Signed-off-by: Nelio Laranjeiro <nelio.laranje...@6wind.com>
> >
>
> Couple of minor comments inline below. Otherwise:
>
> Acked-by: Bruce Richardson <bruce.richard...@intel.com>
>[...]
Hi Bruce,
I'll address those comments in a v4, thanks a lot for your help and
review.
--
Nélio Laranjeiro
6WIND
