Hello Pablo, - All I can see in this patchset is stuff that should remain in the PMD (since this is really specific to them).
- Anyway, if you want to let application get this information, why the new API ? >From my point of view, this should go in rte_eth_dev_info_get(). -- David Marchand On Fri, Sep 26, 2014 at 4:19 PM, Pablo de Lara < pablo.de.lara.guarch at intel.com> wrote: > These patches add two new API functions to get an optimal values > for the RX/TX configuration structures (rte_eth_rxconf and rte_eth_txconf), > so users can get these configurations and modify or use them directly, > to set up RX/TX queues. Besides, most of the apps that were modifying > little > or none of the default values of the structures, have been modified to use > these functions to simplify the code and avoid duplication. > > Pablo de Lara (2): > pmd: Added rte_eth_rxconf_defaults and rte_eth_txconf defaults > functions > app: Used rte_eth_rxconf_defaults and rte_eth_txconf_defaults in apps > > examples/dpdk_qat/main.c | 44 ++----------- > examples/exception_path/main.c | 30 +-------- > examples/ip_fragmentation/main.c | 42 ++----------- > examples/ip_reassembly/main.c | 44 ++----------- > examples/ipv4_multicast/main.c | 44 ++----------- > examples/kni/main.c | 34 +--------- > examples/l2fwd-ivshmem/host/host.c | 43 +----------- > examples/l2fwd/main.c | 48 +------------- > examples/l3fwd-acl/main.c | 46 ++------------ > examples/l3fwd-power/main.c | 46 ++----------- > examples/l3fwd-vf/main.c | 31 ++------- > examples/l3fwd/main.c | 54 +++------------- > examples/link_status_interrupt/main.c | 43 +----------- > examples/load_balancer/init.c | 24 +------ > .../client_server_mp/mp_server/init.c | 41 +----------- > examples/multi_process/l2fwd_fork/main.c | 44 +------------ > examples/multi_process/symmetric_mp/main.c | 36 +--------- > examples/netmap_compat/bridge/bridge.c | 25 ------- > examples/netmap_compat/lib/compat_netmap.c | 6 +- > examples/netmap_compat/lib/compat_netmap.h | 2 - > examples/qos_meter/main.c | 36 ++++------- > examples/quota_watermark/qw/init.c | 26 ++------ > examples/vhost_xen/main.c | 31 ++------- > examples/vmdq/main.c | 60 > ++--------------- > examples/vmdq_dcb/main.c | 36 +--------- > lib/librte_ether/rte_ethdev.c | 68 > ++++++++++++++++++++ > lib/librte_ether/rte_ethdev.h | 29 ++++++++ > lib/librte_pmd_e1000/igb_ethdev.c | 56 > ++++++++++++++++- > lib/librte_pmd_i40e/i40e_ethdev.c | 56 ++++++++++++++++ > lib/librte_pmd_ixgbe/ixgbe_ethdev.c | 59 > +++++++++++++++++ > 30 files changed, 385 insertions(+), 799 deletions(-) > > -- > 1.7.7.6 > >
