Hi Ferruh,
Thanks for you patch.
> -----Original Message-----
> From: Ferruh Yigit <ferruh.yi...@intel.com>
> Sent: Monday, July 2, 2018 6:00 PM
> To: dev-boun...@dpdk.org; dev@dpdk.org
> Cc: nd <n...@arm.com>; Phil Yang <phil.y...@arm.com>
> Subject: Re: [dpdk-dev] [PATCH 1/2] test/link_bonding: disable HW CRC strip by
> default.
>
> On 7/2/2018 9:26 AM, dev-boun...@dpdk.org wrote:
> > Since the tested virtual device has no capacity of HW CRC offload,
> > disable it for the link bonding test by default. Otherwise, it will
> > cause test unexpected failure.
> >
> > Fixes: b219c8c("test: enable HW CRC strip by default")
> >
> > Signed-off-by: Phil Yang <phil.y...@arm.com>
>
> Hi Phil,
>
> There is a patch to add DEV_RX_OFFLOAD_CRC_STRIP to virtual devices [1] and
> there is another under development to remove old offload API [2], those both
> looks like can replace your patch when merged.
>
> [1]: [on next-net] d8b0cfa797d8 ("ethdev: add new offload flag to keep CRC")
"And DEV_RX_OFFLOAD_CRC_STRIP has been added to virtual drivers since
they don't use CRC at all, when an application requires this offload
virtual PMDs should not return error."
I think you have ignored virtual_pmd driver. Since test_link_bonding use
test/virtual_pmd for the testing device.
I unstreamed a patch for this defect. Please review it.
http://patchwork.dpdk.org/patch/42197/
> [2]: https://patches.dpdk.org/patch/40956/
Thanks,
Phil Yang
