Hi Bernard,
<snip>
> This patch fails to compile when applied the current dpdk 18_08 master.
>
> /root/dpdk_sforge_2/app/test-pmd/cmdline.c: In function 'prompt':
> /root/dpdk_sforge_2/app/test-pmd/cmdline.c:17583:3: error: implicit
> declaration of function 'rte_pmd_softnic_manage' [-Werror=implicit-function-
> declaration]
> rte_pmd_softnic_manage(softnic_portid);
> ^
> /root/dpdk_sforge_2/app/test-pmd/cmdline.c:17583:3: error: nested extern
> declaration of 'rte_pmd_softnic_manage' [-Werror=nested-externs]
>
>
> It is also giving the following checkpatch errors and warnings:
>
> WARNING: 'firware' may be misspelled - perhaps 'firmware'?
> #24:
> $ ./testpmd -c 0xc -n 4 --vdev 'net_softnic0,firware=script.cli'
>
> WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
> #33:
> app/test-pmd/{tm.c => softnicfwd.c} | 418
> ++++++++++++------------------------
>
> WARNING: Missing a blank line after declarations
> #107: FILE: app/test-pmd/cmdline.c:17554:
> + uint8_t softnic_enable = 0;
> + if (strcmp(cur_fwd_eng->fwd_mode_name, "softnic") == 0) {
>
> WARNING: line over 80 characters
> #110: FILE: app/test-pmd/cmdline.c:17557:
> + if (strcmp(port->dev_info.driver_name,
> + "net_softnic") == 0) {
>
> WARNING: line over 80 characters
> #163: FILE: app/test-pmd/config.c:2346:
> + if (strcmp(port->dev_info.driver_name,
> + "net_softnic") == 0) {
>
> ERROR: spaces required around that '=' (ctx:WxV)
> #165: FILE: app/test-pmd/config.c:2348:
> + softnic_enable =1;
> ^
>
> WARNING: line over 80 characters
> #171: FILE: app/test-pmd/config.c:2354:
> + printf("Softnicfwd mode configuration not
> + complete(%s)!\n", __func__);
>
> ERROR: space required before the open parenthesis '('
> #208: FILE: app/test-pmd/config.c:2392:
> + if(strcmp(cur_fwd_eng->fwd_mode_name, "softnic") == 0) {
>
> ERROR: space required before the open parenthesis '('
> #437: FILE: app/test-pmd/softnicfwd.c:150:
> + for(;;) {
>
> WARNING: void function return statements are not generally useful
> #445: FILE: app/test-pmd/softnicfwd.c:158:
> + return;
> +}
>
> ERROR: open brace '{' following function definitions go on the next line
> #449: FILE: app/test-pmd/softnicfwd.c:162:
> +static int
> +softnic_begin(void *arg __rte_unused) {
>
> ERROR: space required before the open parenthesis '('
> #456: FILE: app/test-pmd/softnicfwd.c:169:
> + } while(!softnic_fwd_lcore->stopped);
>
> WARNING: void function return statements are not generally useful
> #713: FILE: app/test-pmd/softnicfwd.c:683:
> + return;
> +}
>
> WARNING: adding a line without newline at end of file
> #722: FILE: app/test-pmd/softnicfwd.c:690:
> +};
>
> WARNING: line over 80 characters
> #749: FILE: app/test-pmd/testpmd.c:823:
> + if (strcmp(port->dev_info.driver_name,
> + "net_softnic") == 0)
>
> total: 5 errors, 10 warnings, 768 lines checked
>
> Regards,
>
> Bernard
I am about to send v3 which will address above issues. Thanks you.
Jasvinder
