Hi Jasvinder
> -----Original Message-----
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jasvinder Singh
> Sent: Friday, June 15, 2018 5:52 PM
> To: dev@dpdk.org
> Cc: Dumitrescu, Cristian <cristian.dumitre...@intel.com>; Pattan, Reshma
> <reshma.pat...@intel.com>
> Subject: [dpdk-dev] [PATCH v2 22/22] app/testpmd: rework softnic forward
> mode
>
> Modied the testpmd softnic forwarding mode as per the changes in softnic PMD.
>
> To run testpmd application with softnic fwd mode, following command is used;
>
> $ ./testpmd -c 0xc -n 4 --vdev 'net_softnic0,firware=script.cli'
> -- -i --forward-mode=softnic
>
> Signed-off-by: Jasvinder Singh <jasvinder.si...@intel.com>
> Signed-off-by: Reshma Pattan <reshma.pat...@intel.com>
> ---
> app/test-pmd/Makefile | 4 +-
> app/test-pmd/cmdline.c | 53 ++++-
> app/test-pmd/config.c | 55 +++++
> app/test-pmd/{tm.c => softnicfwd.c} | 418
> ++++++++++++------------------------
> app/test-pmd/testpmd.c | 27 ++-
> app/test-pmd/testpmd.h | 44 +---
> 6 files changed, 256 insertions(+), 345 deletions(-) rename
> app/test-pmd/{tm.c
> => softnicfwd.c} (61%)
>
<snip>
This patch fails to compile when applied the current dpdk 18_08 master.
/root/dpdk_sforge_2/app/test-pmd/cmdline.c: In function 'prompt':
/root/dpdk_sforge_2/app/test-pmd/cmdline.c:17583:3: error: implicit declaration
of function 'rte_pmd_softnic_manage' [-Werror=implicit-function-declaration]
rte_pmd_softnic_manage(softnic_portid);
^
/root/dpdk_sforge_2/app/test-pmd/cmdline.c:17583:3: error: nested extern
declaration of 'rte_pmd_softnic_manage' [-Werror=nested-externs]
It is also giving the following checkpatch errors and warnings:
WARNING: 'firware' may be misspelled - perhaps 'firmware'?
#24:
$ ./testpmd -c 0xc -n 4 --vdev 'net_softnic0,firware=script.cli'
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#33:
app/test-pmd/{tm.c => softnicfwd.c} | 418 ++++++++++++------------------------
WARNING: Missing a blank line after declarations
#107: FILE: app/test-pmd/cmdline.c:17554:
+ uint8_t softnic_enable = 0;
+ if (strcmp(cur_fwd_eng->fwd_mode_name, "softnic") == 0) {
WARNING: line over 80 characters
#110: FILE: app/test-pmd/cmdline.c:17557:
+ if (strcmp(port->dev_info.driver_name, "net_softnic")
== 0) {
WARNING: line over 80 characters
#163: FILE: app/test-pmd/config.c:2346:
+ if (strcmp(port->dev_info.driver_name, "net_softnic")
== 0) {
ERROR: spaces required around that '=' (ctx:WxV)
#165: FILE: app/test-pmd/config.c:2348:
+ softnic_enable =1;
^
WARNING: line over 80 characters
#171: FILE: app/test-pmd/config.c:2354:
+ printf("Softnicfwd mode configuration not complete(%s)!\n",
__func__);
ERROR: space required before the open parenthesis '('
#208: FILE: app/test-pmd/config.c:2392:
+ if(strcmp(cur_fwd_eng->fwd_mode_name, "softnic") == 0) {
ERROR: space required before the open parenthesis '('
#437: FILE: app/test-pmd/softnicfwd.c:150:
+ for(;;) {
WARNING: void function return statements are not generally useful
#445: FILE: app/test-pmd/softnicfwd.c:158:
+ return;
+}
ERROR: open brace '{' following function definitions go on the next line
#449: FILE: app/test-pmd/softnicfwd.c:162:
+static int
+softnic_begin(void *arg __rte_unused) {
ERROR: space required before the open parenthesis '('
#456: FILE: app/test-pmd/softnicfwd.c:169:
+ } while(!softnic_fwd_lcore->stopped);
WARNING: void function return statements are not generally useful
#713: FILE: app/test-pmd/softnicfwd.c:683:
+ return;
+}
WARNING: adding a line without newline at end of file
#722: FILE: app/test-pmd/softnicfwd.c:690:
+};
WARNING: line over 80 characters
#749: FILE: app/test-pmd/testpmd.c:823:
+ if (strcmp(port->dev_info.driver_name, "net_softnic")
== 0)
total: 5 errors, 10 warnings, 768 lines checked
Regards,
Bernard
