Hi Bruce,
Thanks for your review, I submitted v12 patch to address all your new comments.
BTW, do you know why pwclient can NOT work successfully today?
It worked fine at my side previously, any changes at the server side? The error
is below:
xmlrpc.client.ProtocolError: <ProtocolError for dpdk.org/dev/patchwork/xmlrpc/:
301 Moved Permanently>
Best Regards,
Gavin
> -----Original Message-----
> From: Bruce Richardson <bruce.richard...@intel.com>
> Sent: Tuesday, June 19, 2018 6:12 PM
> To: Gavin Hu <gavin...@arm.com>
> Cc: dev@dpdk.org; nd <n...@arm.com>; sta...@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v11 4/6] devtools: fix the missing ninja
> command error
>
> On Tue, Jun 19, 2018 at 09:37:44AM +0800, Gavin Hu wrote:
> > On some linux distributions, eg: CentOS, the ninja executable has a
> > different name: ninja-build, this patch is to check and adapt to it
> > accordingly.
> >
> > ./devtools/test-meson-builds.sh: line 24: ninja: command not found
> >
> > Fixes: a55277a788 ("devtools: add test script for meson builds")
> > Cc: sta...@dpdk.org
> >
> > Signed-off-by: Gavin Hu <gavin...@arm.com>
> > Reviewed-by: Phil Yang <phil.y...@arm.com>
> > Reviewed-by: Song Zhu <song....@arm.com>
> > ---
> This is previously acked.
