> -----Original Message-----
> From: Li, Xiaoyun
> Sent: Wednesday, June 6, 2018 2:17 PM
> To: Xing, Beilei <beilei.x...@intel.com>; Zhang, Qi Z <qi.z.zh...@intel.com>
> Cc: dev@dpdk.org; Li, Xiaoyun <xiaoyun...@intel.com>
> Subject: [PATCH] net/i40e: firmware status check
>
> Check the firmware status at init time. If the status is abnormal, alert the
> user to exit DPDK.
>
> Signed-off-by: Xiaoyun Li <xiaoyun...@intel.com>
> ---
> drivers/net/i40e/i40e_ethdev.c | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
> index 13c5d32..c1c19d3 100644
> --- a/drivers/net/i40e/i40e_ethdev.c
> +++ b/drivers/net/i40e/i40e_ethdev.c
> @@ -1192,7 +1192,7 @@ eth_i40e_dev_init(struct rte_eth_dev *dev, void
> *init_params __rte_unused)
> struct i40e_hw *hw = I40E_DEV_PRIVATE_TO_HW(dev->data-
> >dev_private);
> struct i40e_vsi *vsi;
> int ret;
> - uint32_t len;
> + uint32_t len, val;
> uint8_t aq_fail = 0;
>
> PMD_INIT_FUNC_TRACE();
> @@ -1236,6 +1236,14 @@ eth_i40e_dev_init(struct rte_eth_dev *dev, void
> *init_params __rte_unused)
> hw->bus.func = pci_dev->addr.function;
> hw->adapter_stopped = 0;
>
> + val = I40E_READ_REG(hw, I40E_GL_FWSTS);
> + if (val & I40E_GL_FWSTS_FWS1B_MASK) {
> + PMD_INIT_LOG(ERR, "\nERROR:"
> + " Firmware status of this driver is
> abnormal."
> + " Please quit the app.");
"Please quit the app." can be replaced with some notice, for example "please
check if firmware is updating" and ?
> + return -EIO;
Seems I/O error is not suitable for firmware status. How about EBUSY or
something else?
> + }
> +
> /* Check if need to support multi-driver */
> i40e_support_multi_driver(dev);
>
> --
> 2.7.4
